Bastien Nocera [Mon, 14 Apr 2014 14:40:20 +0000 (16:40 +0200)]
gtkapplication: Fix incorrect value passed to g_variant_new()
The code expected to format @u, not u.
https://bugzilla.gnome.org/show_bug.cgi?id=728140
Cosimo Cecchi [Sun, 4 Aug 2013 14:50:31 +0000 (16:50 +0200)]
iconhelper: always ensure a stated pixbuf
Even when we are set a pixbuf itself.
https://bugzilla.gnome.org/show_bug.cgi?id=726271
Marcus Karlsson [Sat, 12 Apr 2014 08:09:46 +0000 (10:09 +0200)]
GtkColorChooserWidget: Redraw swatches when selection changes
When selecting a swatch in a GtkColorChooserWidget the previously
selected swatch and the currently selected swatch are not redrawn. This
can leave the old swatch still marked with a checkbox even though a new
swatch has been selected.
Redraw the swatches after changing the selection.
https://bugzilla.gnome.org/show_bug.cgi?id=727487
Marcus Karlsson [Tue, 8 Apr 2014 20:40:01 +0000 (22:40 +0200)]
docs: fix GtkWidget::size-allocate description
The documentation for the GtkWidget::size-allocate signal is missing the
description of the "allocation" parameter. Add the missing description
to the parameter.
https://bugzilla.gnome.org/show_bug.cgi?id=726179
Sébastien Wilmet [Fri, 11 Apr 2014 15:45:50 +0000 (17:45 +0200)]
GtkTextView: use GSlice to allocate GtkTextLineSegment's
Use GSlice to allocate all types of segments:
- char
- toggle
- mark
- pixbuf
- child widget
Char segments are a bit more complicated because the length of the text
is determined at run time and stored in the 'byte_count' field. If the
text is long, GSlice will call the system malloc() anyway, so it's
better to always use GSlice for GtkTextLineSegment.
Toggle segments are also freed in gtktextbtree.c, hence the function
_gtk_toggle_segment_free() (for a later commit it would be nice to
rename those functions with the _gtk_text prefix).
https://bugzilla.gnome.org/show_bug.cgi?id=727908
Sébastien Wilmet [Wed, 9 Apr 2014 14:53:14 +0000 (16:53 +0200)]
textview: inline a function
gtk_text_view_move_cursor_internal() was exactly the same as
gtk_text_view_move_cursor(), and was called only in the latter function.
https://bugzilla.gnome.org/show_bug.cgi?id=727908
Sébastien Wilmet [Tue, 8 Apr 2014 20:43:25 +0000 (22:43 +0200)]
doc: improve documentation of gtk_text_iter_inside_word()
There is a possible confusion with the sentence:
"@iter is inside a natural-language word"
The iter should be viewed here as the pointed character (i.e. on the
right of the iter), not as a position between two characters.
Instead of improving the documentation, another solution would have been
to change the implementation so it is interpreted as an iter position
inside a word, i.e. between two characters that are part of a
natural-language word. But maybe some applications rely on the current
implementation.
https://bugzilla.gnome.org/show_bug.cgi?id=727908
Sébastien Wilmet [Tue, 8 Apr 2014 19:36:45 +0000 (21:36 +0200)]
tests textiter: test word boundaries
- As the tests show, some of the functions have a strange and
inconsistent behavior for corner cases.
- Rename test_full_buffer() -> test_search_full_buffer() because
textiter.c is used for other GtkTextIter unit tests.
https://bugzilla.gnome.org/show_bug.cgi?id=727908
Matthias Clasen [Sun, 13 Apr 2014 21:03:12 +0000 (14:03 -0700)]
listbox: Add tests for multi-selection
This was forgotten when the multi-selection API was added,
and it was promptly broken in some places.
Matthias Clasen [Sun, 13 Apr 2014 20:55:28 +0000 (13:55 -0700)]
list-box: Fix copy-paste error
The new function gtk_list_box_get_selected_rows was implemented
as gtk_list_box_get_selected_children.
Matthias Clasen [Sun, 13 Apr 2014 20:51:49 +0000 (13:51 -0700)]
listbox: Emit ::row-selected as we used to
The listbox selection test was failing because we were not
emitting these signals anymore.
Marcus Karlsson [Sat, 12 Apr 2014 18:22:15 +0000 (20:22 +0200)]
docs: Add missing transfer annotation to GtkBox
The gtk_box_get_center_widget function is missing a transfer annotation
for the returned widget. No transfer is done, so set transfer to none.
https://bugzilla.gnome.org/show_bug.cgi?id=728093
Matthias Clasen [Sun, 13 Apr 2014 05:13:40 +0000 (22:13 -0700)]
gtk-demo: Avoid a compiler warning
Matthias Clasen [Sun, 13 Apr 2014 05:13:14 +0000 (22:13 -0700)]
widget-factory: Clean up on shutdown
Matthias Clasen [Sun, 13 Apr 2014 05:12:38 +0000 (22:12 -0700)]
widget-factory: Remove unnecessary signal handlers
quitting the mainloop when none is running gives a critical
warning on shutdown.
Matthias Clasen [Sun, 13 Apr 2014 04:45:30 +0000 (21:45 -0700)]
widget-factory: Add a listbox example
Matthias Clasen [Sun, 13 Apr 2014 04:09:03 +0000 (21:09 -0700)]
widget-factory: Improve actionbar appearance
We are using the actionbar in the middle of the window, which
is not really what it is designed for. To avoid the unfinished
appearance on the sides, move it into the frame that we have
around the stack below. This fixes the sides, but gives the top
a double stroke. Too bad.
Matthias Clasen [Sun, 13 Apr 2014 03:46:17 +0000 (20:46 -0700)]
widget-factory: Avoid ugly resizing on map
The text view is resizing several times after the window is mapped.
Not setting a hscrollbar-policy of never avoids that, and a
scrollbar still doesn't appear. Magic
Matthias Clasen [Sun, 13 Apr 2014 03:39:26 +0000 (20:39 -0700)]
gtk-demo: Fix images demo
The incremental loading was broken by GtkIconHelper - queuing a
redraw is no longer sufficient to cause GtkImage to redraw with
the new pixbuf contents.
Pointed out by Jasper St. Pierre.
Matthias Clasen [Sun, 13 Apr 2014 01:42:29 +0000 (18:42 -0700)]
gtk-demo: Fix the links example
The keynav dialog is transient to the example window; since the
example window is now modal, we need to make the keynav dialog
modal as well, so it can receive input.
Problem pointed out by Jasper St. Pierre.
Jasper St. Pierre [Sat, 12 Apr 2014 00:02:45 +0000 (17:02 -0700)]
Remove gdk_synthesize_window_state from gdkinternals.h
It's already in gdkprivate.h
Jasper St. Pierre [Fri, 11 Apr 2014 23:55:37 +0000 (16:55 -0700)]
wayland: set_transient_for was renamed to set_parent
Jasper St. Pierre [Fri, 11 Apr 2014 23:53:05 +0000 (16:53 -0700)]
wayland: Don't pass dx/dy when we're resizing
They're ignored by the server.
Jasper St. Pierre [Sun, 23 Feb 2014 18:57:24 +0000 (13:57 -0500)]
wayland: Merge buffer implementations
Matthias Clasen [Sat, 5 Apr 2014 15:43:43 +0000 (11:43 -0400)]
window: Be more careful when propagating key events
We are keeping references on the widget we are handling as we
are iterating up, but that doesn't protect us against the entire
tree being axed from inside gtk_widget_handle_event.
https://bugzilla.gnome.org/show_bug.cgi?id=727644
Cosimo Cecchi [Fri, 11 Apr 2014 19:13:11 +0000 (12:13 -0700)]
entry: consider ascent and descent when requesting height
Commit
d05191a010bcd9871b0155a785989192967c692b change the height
requisition to be completely dependent on the PangoLayout, but that
breaks when the font has special characters with different metrics.
Use the maximum between the two instead.
https://bugzilla.gnome.org/show_bug.cgi?id=728054
Bastien Nocera [Fri, 11 Apr 2014 08:53:45 +0000 (10:53 +0200)]
gtkapplication: Fix passing NULL as the window to inhibit
gtk_application_inhibit() supports passing NULL, so don't
blindly pass the NULL window to
gtk_application_impl_dbus_get_window_system_id().
https://bugzilla.gnome.org/show_bug.cgi?id=728023
Matthias Clasen [Thu, 10 Apr 2014 22:50:51 +0000 (15:50 -0700)]
Update expected output for assistant a11y test
The headerbar and its content now shows up, as it should.
Matthias Clasen [Thu, 10 Apr 2014 21:22:46 +0000 (14:22 -0700)]
GtkAssistant: don't hide headerbar from a11y
GtkAssistant has its own accessible implementation, and we forgot
to update it when we added a headerbar.
Matthias Clasen [Thu, 10 Apr 2014 20:51:33 +0000 (13:51 -0700)]
GtkMessageDialog: Allow action-area-border theming again
This border does not interfere with headerbar-vs-content placement,
and we can allow themes to change it without breaking dialogs.
Matthias Clasen [Thu, 10 Apr 2014 20:49:07 +0000 (13:49 -0700)]
GtkDialog: fix up handling of style properties
The use of border-width-set here was an attempt to differentiate
between explicitly set (from code / ui files) border width from
theme changes. But when we are calling gtk_window_set_border_width
to apply the theme value, the -set property gets set, and all
further theme changes are ignored. This has the effect of only
letting the default value of these properties get applied.
Fix this by unsetting border-width-set after applying theme values.
Руслан Ижбулатов [Thu, 10 Apr 2014 17:59:48 +0000 (17:59 +0000)]
Revert "W32: RGBA GDK backend (broken)"
This reverts commit
f89d38bc2d139ae1baab5c25e1d6ac451a2d5a5e.
Pushed by accident.
Руслан Ижбулатов [Thu, 10 Apr 2014 17:59:21 +0000 (17:59 +0000)]
Revert "W32: Add a basic set of CSD styles"
This reverts commit
6e3e0dcd739bcf7ef549cecc0aa5061c794e14bb.
Pushed by accident.
Руслан Ижбулатов [Thu, 10 Apr 2014 17:58:58 +0000 (17:58 +0000)]
Revert "W32: Implement composition check for GDK"
This reverts commit
7ae5a56948e5124eabd558438ff29187f5721819.
Pushed by accident.
Руслан Ижбулатов [Thu, 10 Apr 2014 15:33:41 +0000 (15:33 +0000)]
W32: remove border on default buttons
https://bugzilla.gnome.org/show_bug.cgi?id=727973
Руслан Ижбулатов [Thu, 10 Apr 2014 08:48:13 +0000 (08:48 +0000)]
W32: Implement composition check for GDK
Also move DWM function grabbing and make those functions available to all of GDK-Win32.
https://bugzilla.gnome.org/show_bug.cgi?id=727316
Руслан Ижбулатов [Mon, 7 Apr 2014 04:39:40 +0000 (04:39 +0000)]
W32: Add a basic set of CSD styles
https://bugzilla.gnome.org/show_bug.cgi?id=727316
Руслан Ижбулатов [Sat, 29 Mar 2014 21:28:33 +0000 (21:28 +0000)]
W32: RGBA GDK backend (broken)
https://bugzilla.gnome.org/show_bug.cgi?id=727316
Benjamin Otte [Thu, 10 Apr 2014 15:06:27 +0000 (17:06 +0200)]
tests: Don't use deprecated functions in testselection
Benjamin Otte [Thu, 10 Apr 2014 15:00:44 +0000 (17:00 +0200)]
tests: Make testlockbutton not use deprecated API
Benjamin Otte [Thu, 10 Apr 2014 14:53:42 +0000 (16:53 +0200)]
testgtk: Don't use deprecated functions in selection test
Benjamin Otte [Thu, 10 Apr 2014 14:50:32 +0000 (16:50 +0200)]
testgtk: Remove rc file test
The test didn't work anymore since RC files stopped being used in 3.0.
Benjamin Otte [Thu, 10 Apr 2014 14:48:13 +0000 (16:48 +0200)]
testgtk: Don't use deprecated functions in progress bar test
Benjamin Otte [Thu, 10 Apr 2014 14:45:37 +0000 (16:45 +0200)]
testgtk: Don't use deprecated functions in event watcher test
Benjamin Otte [Thu, 10 Apr 2014 14:42:59 +0000 (16:42 +0200)]
testgtk: Don't use deprecated functions in scrolled windows test
Benjamin Otte [Thu, 10 Apr 2014 14:35:51 +0000 (16:35 +0200)]
testgtk: Don't use deprecated functions in dialogs test
Benjamin Otte [Thu, 10 Apr 2014 14:16:41 +0000 (16:16 +0200)]
testgtk: Make dialogs example work without static variable
Makes it a bit more complicated, but meh.
Benjamin Otte [Thu, 10 Apr 2014 14:07:05 +0000 (16:07 +0200)]
testgtk: Clean up dialog example
Don't pass a static variable to a callback, when the static variable
could just be deinfed in the callback.
Benjamin Otte [Thu, 10 Apr 2014 12:28:44 +0000 (14:28 +0200)]
testgtk: Don't use deprecated functions in flipping test
Benjamin Otte [Thu, 10 Apr 2014 00:40:49 +0000 (02:40 +0200)]
testgtk: Don't use deprecated functions in scrolling test
Benjamin Otte [Thu, 10 Apr 2014 00:36:38 +0000 (02:36 +0200)]
testgtk: Don't call deprecated function in mainloop test
Benjamin Otte [Thu, 10 Apr 2014 00:29:54 +0000 (02:29 +0200)]
tests: Add deprecation guards
Benjamin Otte [Wed, 9 Apr 2014 23:53:57 +0000 (01:53 +0200)]
pixelcache: Add a warning for an invariant that shouldn't happen
Pixel caches should be unmapped before being freed and unmapping clears
those variables.
Benjamin Otte [Wed, 9 Apr 2014 22:15:05 +0000 (00:15 +0200)]
textview: Call map/unmap functions on pixel cache
https://bugzilla.gnome.org/show_bug.cgi?id=726475
Benjamin Otte [Wed, 9 Apr 2014 21:34:57 +0000 (23:34 +0200)]
treeview: Call map/unmap functions on pixel cache
https://bugzilla.gnome.org/show_bug.cgi?id=726475
Benjamin Otte [Wed, 9 Apr 2014 21:34:40 +0000 (23:34 +0200)]
viewport: Call map/unmap functions on pixel cache
https://bugzilla.gnome.org/show_bug.cgi?id=726475
Benjamin Otte [Wed, 9 Apr 2014 21:31:21 +0000 (23:31 +0200)]
pixelcache: Add map/unmap functions
Because GTK does not invalidate windows that aren't mapped, we cannot
update the pixel cache when the window it handles isn't mapped. So we
add API to call when GDK windows get mapped/unmapped.
https://bugzilla.gnome.org/show_bug.cgi?id=726475
Benjamin Otte [Wed, 9 Apr 2014 21:28:50 +0000 (23:28 +0200)]
pixelcache: Split out a function
https://bugzilla.gnome.org/show_bug.cgi?id=726475
Chun-wei Fan [Wed, 9 Apr 2014 06:03:01 +0000 (14:03 +0800)]
Visual C++ Builds: Fix Header Installation
Make sure that gtk/a11y/gtkpopoveraccessible.h is copied, so that programs
using GTK+'s a11y will compile correctly.
Yuri Myasoedov [Tue, 8 Apr 2014 20:22:57 +0000 (00:22 +0400)]
Fixed Russian translation
Matthias Clasen [Tue, 8 Apr 2014 03:17:56 +0000 (23:17 -0400)]
listbox: keep emitting ::row-selected
This was accidentally lost when multi-selection was added, causing
sidebars like the one in gnome-contacts or polari to not work any
more.
Piotr Drąg [Sun, 6 Apr 2014 11:10:52 +0000 (13:10 +0200)]
doap: update URLs
Yosef Or Boczko [Sun, 9 Feb 2014 15:51:52 +0000 (17:51 +0200)]
headerbar: Use popover for the fallback app menu
https://bugzilla.gnome.org/show_bug.cgi?id=723963
Matthias Clasen [Sun, 6 Apr 2014 06:13:06 +0000 (02:13 -0400)]
Deprecate gtk_application_add_accelerator
The new gtk_application_set_accels_for_action api is more flexible
and better.
Matthias Clasen [Sun, 6 Apr 2014 05:52:24 +0000 (01:52 -0400)]
Add new switch api to the docs
Matthias Clasen [Sat, 29 Mar 2014 17:41:25 +0000 (13:41 -0400)]
Add a delayed state test case
This adds a switch with delayed state change to testswitch,
demonstrating the functionality that was added in the previous
commit.
Matthias Clasen [Sat, 29 Mar 2014 17:40:08 +0000 (13:40 -0400)]
switch: Add a delayed state capability
This commit makes it possible for GtkSwitch to indicate when
the underlying state changes with a delay, causing the switch
to temporarily go 'out of sync' with the underlying change.
https://bugzilla.gnome.org/show_bug.cgi?id=725648
Matthias Clasen [Sun, 6 Apr 2014 05:51:38 +0000 (01:51 -0400)]
Add new listbox api to docs
Matthias Clasen [Sat, 29 Mar 2014 05:03:06 +0000 (01:03 -0400)]
list box: Avoid excessive signals
We were emitting the a11y ::selection-changed signal much more
often than ::selected-rows-changed. Thats not necessary.
Matthias Clasen [Sat, 29 Mar 2014 04:59:05 +0000 (00:59 -0400)]
Improve list selection example
Print out signals, so we see how often they are emitted.
Matthias Clasen [Sat, 29 Mar 2014 03:07:41 +0000 (23:07 -0400)]
list box: Cosmetic changes
Shorten variable names from list_box to box, throughout,
and use the BOX_PRIV macro everywhere.
Matthias Clasen [Sat, 29 Mar 2014 01:48:54 +0000 (21:48 -0400)]
Add a list box selection testcase
Matthias Clasen [Sat, 29 Mar 2014 02:10:27 +0000 (22:10 -0400)]
list box: Update accessible implementation
Now that multi selection is supported, we can provide a more
complete AtkSelection implementation.
Matthias Clasen [Sat, 29 Mar 2014 01:34:39 +0000 (21:34 -0400)]
list box: Implement multiple selection
This largely copies the flox box implementation, including the
same key bindings.
Matthias Clasen [Fri, 28 Mar 2014 23:21:57 +0000 (19:21 -0400)]
listbox: Add multi-selection API
This commit adds API for dealing with multi-selection. It is identical
to the flow box API for this purpose. The implementation is still limited
to single-selection, and will be updated in subsequent commits.
Matthias Clasen [Sat, 29 Mar 2014 01:50:44 +0000 (21:50 -0400)]
Add version macros for 3.14
Matthias Clasen [Sun, 6 Apr 2014 05:26:27 +0000 (01:26 -0400)]
Bump version to 3.13
John Lindgren [Sat, 5 Apr 2014 14:07:25 +0000 (10:07 -0400)]
Set use-fallback property to True for GtkScaleButton icons.
https://bugzilla.gnome.org/show_bug.cgi?id=727662
Jasper St. Pierre [Sun, 6 Apr 2014 02:44:00 +0000 (22:44 -0400)]
Make GtkAccelGroupEntry public again
Even though it was marked as internal, it seems gnome-terminal was
poking into the structure. It's unfortunately part of our ABI.
Matthias Clasen [Sat, 5 Apr 2014 15:21:50 +0000 (11:21 -0400)]
overlay: deal gracefully with main widget being absent
It can happen that we get a size request when the main widget
is still NULL. Currently we hit a critical in this case, and
stumble on. We can do better.
Opening a new tab in nautilus is hitting this case.
https://bugzilla.gnome.org/show_bug.cgi?id=727643
Matthias Clasen [Sat, 5 Apr 2014 06:04:12 +0000 (02:04 -0400)]
Clean up private headers
This commit adds a few missing private headers, and cleans up
some irregularities in the existing ones
maria thukididu [Fri, 4 Apr 2014 12:28:43 +0000 (15:28 +0300)]
Updated Greek translation
maria thukididu [Fri, 4 Apr 2014 12:25:46 +0000 (15:25 +0300)]
Updated Greek translation
Руслан Ижбулатов [Wed, 2 Apr 2014 17:42:31 +0000 (17:42 +0000)]
W32: Give unfocused selected list items special background, like Explorer does
https://bugzilla.gnome.org/show_bug.cgi?id=727244
Matthias Clasen [Fri, 4 Apr 2014 05:28:09 +0000 (01:28 -0400)]
csd: Drop the GTK_FRAME_EXTENTS requirement
We are getting bug reports from people who are irritated that
dialogs now have 'double headers' under any wm but gnome-shell.
As an example, xfwm4 seems to do ok with csd windows, and
on balance it seems better to have some invisible border issues
than to have double headers.
https://bugzilla.gnome.org/show_bug.cgi?id=727414
Matthias Clasen [Fri, 4 Apr 2014 05:25:14 +0000 (01:25 -0400)]
docs: More uniform formatting
Make all occurrences of hex in gdkcolor.c use “.
Volker Sobek [Fri, 28 Mar 2014 20:55:03 +0000 (21:55 +0100)]
docs: Remove '\' escape character from literals
commit
7f6a964c47ad2f9dcf6a00044d938840ce8f01f2 replaced entities, but
escaped the replacement text also inside literals, which resulted in the
escaping '\' to also appear in the documentation.
https://bugzilla.gnome.org/show_bug.cgi?id=727322
Sébastien Wilmet [Thu, 3 Apr 2014 16:22:31 +0000 (18:22 +0200)]
doc: fix gtk_window_destroy() -> gtk_widget_destroy()
Reviewed-by: Emmanuele Bassi
Chun-wei Fan [Thu, 3 Apr 2014 07:49:05 +0000 (15:49 +0800)]
Visual C++ Builds: Build Introspection for GdkWin32
Add support to build the introspection files for GdkWin32, as done recently
in the autotools builds and clean up the NMake Makefile for building the
introspection files a bit.
For some reason, gdk_win32_display_manager_get_type() was not exported in
gdk-3.0.lib, force its export, so that the GdkWin32-3.0.gir can be built
properly with the Visual C++ builds. This is a known problem that some
symbols in static libraries that are linked into a DLL in Visual C++, even
if they were marked with __declspec(dllexport) via _GDK_EXTERN.
Chun-wei Fan [Thu, 3 Apr 2014 07:07:44 +0000 (15:07 +0800)]
MSVC Builds: Clean up gtk-version-paths.*props
Remove lines that are not really referred to.
Matthias Clasen [Wed, 2 Apr 2014 16:41:24 +0000 (12:41 -0400)]
Drop an unnecessary include
These tests are better if they can be built standalone.
Matthias Clasen [Wed, 2 Apr 2014 13:51:01 +0000 (09:51 -0400)]
Add a big combobox test case
I've seen many bugs about long combo box popups getting misplaced
or wrongly sized. Time to add a testcase.
Jonas Danielsson [Sat, 29 Mar 2014 20:51:31 +0000 (21:51 +0100)]
a11y: atk_table_get_row_at_index is deprecated
Do not use deprecated index based AtkTable functions use static
helper instead.
https://bugzilla.gnome.org/show_bug.cgi?id=727313
Jonas Danielsson [Sat, 29 Mar 2014 20:48:43 +0000 (21:48 +0100)]
a11y: atk_component_get_position is deprecated
Switch to using atk_component_get_extents instead.
https://bugzilla.gnome.org/show_bug.cgi?id=727313
Michael Natterer [Tue, 1 Apr 2014 23:03:54 +0000 (01:03 +0200)]
treeview: remove unused members from GtkTreeView Private
Pau Iranzo [Tue, 1 Apr 2014 21:56:51 +0000 (23:56 +0200)]
[l10n] Update Catalan translation
Руслан Ижбулатов [Mon, 31 Mar 2014 16:01:55 +0000 (16:01 +0000)]
W32: style tooltips with appropriately-themed background
https://bugzilla.gnome.org/show_bug.cgi?id=727410
Руслан Ижбулатов [Mon, 31 Mar 2014 15:54:09 +0000 (15:54 +0000)]
W32: give scrollbar slider active and insensitive styles
https://bugzilla.gnome.org/show_bug.cgi?id=727391
Руслан Ижбулатов [Fri, 28 Mar 2014 14:03:30 +0000 (14:03 +0000)]
Give CC to instrospection scanner
Introspection scanner-generation script gets compiler from the CC
environment, we need to set it.
https://bugzilla.gnome.org/show_bug.cgi?id=722817
Руслан Ижбулатов [Fri, 28 Mar 2014 14:02:39 +0000 (14:02 +0000)]
Introspection for gdk-win32
https://bugzilla.gnome.org/show_bug.cgi?id=722817